Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): RobotContext: Add gripper commands #16752

Merged
merged 39 commits into from
Nov 26, 2024

Conversation

Laura-Danielle
Copy link
Contributor

Overview

Adding RobotContext gripper commands.

Test Plan and Hands on Testing

Check that the gripper can open and close using the robot context commands.

Changelog

  • Update the release/grip robot_context commands
  • Add protocol engine commands
  • Add tests

Review requests

Check that the paths make sense

Risk assessment

Low. Unrelease protocol API.

@Laura-Danielle Laura-Danielle requested a review from a team as a code owner November 8, 2024 23:07
@sfoster1 sfoster1 changed the base branch from edge to PLAT-453-PLAT-454-add-pipette-support-functions November 13, 2024 17:49
@sfoster1 sfoster1 changed the title feat(robot_context): Add gripper commands feat(api): RobotContext: Add gripper commands Nov 13, 2024
@sfoster1 sfoster1 changed the base branch from PLAT-453-PLAT-454-add-pipette-support-functions to edge November 13, 2024 17:50
@sfoster1
Copy link
Member

@Laura-Danielle Can you rebase this on top of the pipette one and target it there or something? It's really hard to see what changed in just this PR vs that one.

@Laura-Danielle Laura-Danielle force-pushed the PLAT-353-PLAT-354-add-gripper-commands branch from 563be9b to 736370a Compare November 21, 2024 14:49
@Laura-Danielle Laura-Danielle requested a review from a team as a code owner November 21, 2024 15:50
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty happy with this!

@Laura-Danielle Laura-Danielle merged commit 825e2af into edge Nov 26, 2024
67 checks passed
@Laura-Danielle Laura-Danielle deleted the PLAT-353-PLAT-354-add-gripper-commands branch November 26, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants